-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate some interface dispatch around object pool use #1205
Conversation
9ceaf2c
to
0d84132
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1205 +/- ##
==========================================
- Coverage 83.31% 83.30% -0.02%
==========================================
Files 277 275 -2
Lines 6286 6282 -4
Branches 1023 1023
==========================================
- Hits 5237 5233 -4
Misses 844 844
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering what's the real impact of this change.
Can you run the Polly.Core.Benchmarks
(at least for timeout startegy) to see the difference?
edit: the benchmarking needed some love, so I addressed this here:
#1206
The benchmark around combining the pool types into one were inconclusive, so I just undid that part of the PR. |
The issue or feature being addressed
Details on the issue fix or feature implementation
Confirm the following