Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Polly.Core README.md #1298

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Cleanup Polly.Core README.md #1298

merged 2 commits into from
Jun 14, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 14, 2023

Details on the issue fix or feature implementation

Just improving the readme file before alpha release.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 14, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1298 (78c0559) into main (155a062) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         263      263           
  Lines        6299     6299           
  Branches      994      994           
=======================================
  Hits         5246     5246           
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
macos 83.28% <ø> (ø)
windows 83.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

```
- [ResilienceStrategyBuilder](ResilienceStrategyBuilder.cs): Used to create resilience strategies that can execute all types of callbacks. In general, these strategies only handle exceptions.
- [ResilienceStrategyBuilder<T>](ResilienceStrategyBuilder.TResult.cs): Used to create generic resilience strategies that can only execute callbacks that return the same result type.
- [ResilienceStrategyBuilderBase](ResilienceStrategyBuilderBase.cs): The base class for both builders above. You can use is as a target for strategy extension that work for both builders above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ResilienceStrategyBuilderBase](ResilienceStrategyBuilderBase.cs): The base class for both builders above. You can use is as a target for strategy extension that work for both builders above.
- [ResilienceStrategyBuilderBase](ResilienceStrategyBuilderBase.cs): The base class for both builders above. You can use it as a target for strategy extensions that work for both builders above.

@martintmk martintmk enabled auto-merge (squash) June 14, 2023 12:56
@martintmk martintmk merged commit 833ad99 into main Jun 14, 2023
@martintmk martintmk deleted the mtomka/cleanup-readme branch June 14, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants