Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop redundant validation of resilience strategy options #1299

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 15, 2023

Details on the issue fix or feature implementation

These are already validated by base builder so no need to do it twice.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 15, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1299 (f695c92) into main (833ad99) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   83.28%   83.28%   -0.01%     
==========================================
  Files         263      264       +1     
  Lines        6299     6298       -1     
  Branches      994      996       +2     
==========================================
- Hits         5246     5245       -1     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
macos 83.28% <100.00%> (-0.01%) ⬇️
windows 83.28% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rcuitBreakerResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...ging/HedgingResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...eout/TimeoutResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
.../RateLimiterResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyBuilderBase.cs 100.00% <100.00%> (ø)
src/Polly.Core/Utils/TypeNameFormatter.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit c782d81 into main Jun 15, 2023
@martintmk martintmk deleted the mtomka/drop-redundant-validation branch June 15, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants