Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for .NET 8 #1360

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Conversation

martincostello
Copy link
Member

Port various changes from #1144:

  • Simplify NuGet package version management.
  • Simplify TimeProviderExtensions.
  • Enable .NET analyzers.
  • Remove MockTimeProvider.
  • Minor code formatting clean-ups.

Also updates the Cake dependencies to their latest versions.

@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Jun 27, 2023
@martincostello martincostello added this to the v8.0.0 milestone Jun 27, 2023
Copy link
Contributor

@martintmk martintmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1360 (e07e179) into main (f803198) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head e07e179 differs from pull request most recent head 3213738. Consider uploading reports for the commit 3213738 to get more accurate results

@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
+ Coverage   83.51%   83.56%   +0.05%     
==========================================
  Files         268      268              
  Lines        6362     6382      +20     
  Branches      999     1001       +2     
==========================================
+ Hits         5313     5333      +20     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.56% <100.00%> (?)
macos 83.56% <100.00%> (+0.05%) ⬆️
windows 83.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/TimeProviderExtensions.cs 100.00% <100.00%> (ø)

Backport various changes from App-vNext#1144:
- Simplify NuGet package version management.
- Simplify TimeProviderExtensions.
- Enable .NET analyzers.
- Remove `MockTimeProvider`.
- Minor code formatting clean-ups.
Update the Cake dependencies to their latest versions.
Revert unnecessary change to test.
Add comment as requested in peer review.
@martincostello martincostello enabled auto-merge (rebase) June 27, 2023 09:00
@martincostello martincostello merged commit 190f096 into App-vNext:main Jun 27, 2023
7 checks passed
@martincostello martincostello deleted the dotnet-8-prep branch June 27, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants