Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding generic strategies to generic builder #1386

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 4, 2023

Details on the issue fix or feature implementation

Noticed that this API is missing while testing the latest alpha.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 4, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 4, 2023
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1386 (04019d3) into main (22df640) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files         269      269           
  Lines        6429     6429           
  Branches     1004     1003    -1     
=======================================
  Hits         5380     5380           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux 83.68% <100.00%> (ø)
macos 83.68% <100.00%> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Polly.Core/ResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@martintmk martintmk enabled auto-merge (squash) July 4, 2023 07:23
@martintmk martintmk merged commit 2de8fc0 into main Jul 4, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/addgenericstrategy branch July 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants