Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate the library with trimming attributes #1414

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 19, 2023

Details on the issue fix or feature implementation

Use trimming attributes and resolve the trimming warnings. With this change the AOT compilation works correctly (including the options validation).

Closes #1110

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1414 (d111b6b) into main (38d903e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   83.81%   83.83%   +0.02%     
==========================================
  Files         274      274              
  Lines        6482     6491       +9     
  Branches     1009     1008       -1     
==========================================
+ Hits         5433     5442       +9     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.83% <100.00%> (+0.02%) ⬆️
macos 83.83% <100.00%> (+0.02%) ⬆️
windows 83.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/AdvancedCircuitBreakerStrategyOptions.TResult.cs 100.00% <ø> (ø)
...re/CircuitBreaker/CircuitBreakerStrategyOptions.cs 100.00% <ø> (ø)
.../Polly.Core/ResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <ø> (ø)
...olly.Core/Telemetry/ResilienceStrategyTelemetry.cs 100.00% <ø> (ø)
...eout/TimeoutResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/Timeout/TimeoutStrategyOptions.cs 100.00% <ø> (ø)
...ions/Registry/ConfigureBuilderContextExtensions.cs 100.00% <ø> (ø)
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <ø> (ø)
...ry/TelemetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
... and 8 more

@@ -1,7 +1,6 @@
using System.ComponentModel;

using System.ComponentModel.DataAnnotations;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete the line above rather than below?

@martintmk martintmk merged commit dd14ca6 into main Jul 20, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/trimming-attributes branch July 20, 2023 05:46
martincostello added a commit to martincostello/Polly that referenced this pull request Jul 20, 2023
Some minor updates to the trimming annotations added in App-vNext#1414.
martincostello added a commit that referenced this pull request Jul 20, 2023
Some minor updates to the trimming annotations added in #1414.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Investigate native AOT compatibility
2 participants