Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ResilienceContextPool (ApiReview) #1421

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 21, 2023

Details on the issue fix or feature implementation

Contributes to #1365

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 21, 2023
/// <summary>
/// The shared pool instance.
/// </summary>
public static readonly ResilienceContextPool Shared = new SharedPool();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a property rather than a field?

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1421 (75e29eb) into main (02a1944) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
- Coverage   83.75%   83.74%   -0.01%     
==========================================
  Files         274      276       +2     
  Lines        6456     6454       -2     
  Branches     1007     1007              
==========================================
- Hits         5407     5405       -2     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.74% <100.00%> (-0.01%) ⬇️
macos 83.74% <100.00%> (-0.01%) ⬇️
windows 83.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Core/CircuitBreaker/CircuitBreakerManualControl.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContextPool.Shared.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContextPool.cs 100.00% <100.00%> (ø)
...c/Polly.Core/ResilienceStrategy.Async.ValueTask.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResilienceStrategy.Async.ValueTaskT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.Sync.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.SyncT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.cs 100.00% <100.00%> (ø)
... and 2 more

src/Polly.sln Outdated Show resolved Hide resolved
@martintmk martintmk merged commit 7f6b8a4 into main Jul 21, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/introduce-ResilienceContextPool branch July 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants