Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging messages #1436

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Improve logging messages #1436

merged 3 commits into from
Jul 26, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 26, 2023

Details on the issue fix or feature implementation

Closes #1435

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 26, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1436 (5b656da) into main (b38e6c4) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   83.91%   83.92%           
=======================================
  Files         276      276           
  Lines        6523     6524    +1     
  Branches     1005     1006    +1     
=======================================
+ Hits         5474     5475    +1     
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux 83.92% <100.00%> (+<0.01%) ⬆️
macos 83.92% <100.00%> (+<0.01%) ⬆️
windows 83.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <100.00%> (ø)
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Extensions/Telemetry/TelemetryUtil.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 7dc06c0 into main Jul 26, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/improve-logging branch July 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Confusing log entries when builder instance name not set
2 participants