Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and enhance the pipeline reloads #1512

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 24, 2023

Details on the issue fix or feature implementation

This change simplifies the API and allows listening to multiple reload tokens.

Essentially, the caller can now do:

services.AddResiliencePipeline("my-pipeline", (builder, context) =>
{
    context.EnableReloads<Options1>();
    context.EnableReloads<Options2>();
   
    // add strategies
});

Whenever Options1 or Options2 are changed, the pipeline is reloaded. Previously, the pipeline could listen only to a single options.

Enabled by #1511
Contributes to #1507

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 24, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1512 (ad5ba8a) into main (3c76e05) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   84.01%   84.02%   +0.01%     
==========================================
  Files         275      274       -1     
  Lines        6542     6547       +5     
  Branches     1022     1024       +2     
==========================================
+ Hits         5496     5501       +5     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 84.02% <100.00%> (+0.01%) ⬆️
windows 84.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Registry/ConfigureBuilderContext.cs 100.00% <100.00%> (ø)
....Core/Registry/RegistryPipelineComponentBuilder.cs 100.00% <100.00%> (ø)
...ly.Core/Utils/Pipeline/PipelineComponentFactory.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Utils/Pipeline/ReloadableComponent.cs 100.00% <100.00%> (ø)
...ions/Registry/ConfigureBuilderContextExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 8aa9df2 into main Aug 24, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/reload-simplification branch August 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants