Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DelayAsync extension #1525

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Fix DelayAsync extension #1525

merged 4 commits into from
Aug 30, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 30, 2023

Details on the issue fix or feature implementation

Follow-up of #1522 (also fixes the build)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 30, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (daf1529) 84.11% compared to head (f121912) 84.02%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   84.11%   84.02%   -0.10%     
==========================================
  Files         278      278              
  Lines        6586     6546      -40     
  Branches     1026     1024       -2     
==========================================
- Hits         5540     5500      -40     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 84.02% <100.00%> (-0.10%) ⬇️
windows 84.02% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcuitBreakerResiliencePipelineBuilderExtensions.cs 100.00% <ø> (ø)
...Core/CircuitBreaker/CircuitBreakerStateProvider.cs 100.00% <ø> (ø)
...ack/FallbackResiliencePipelineBuilderExtensions.cs 100.00% <ø> (ø)
...ly.Core/Hedging/HedgingActionGeneratorArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Hedging/HedgingConstants.cs 100.00% <ø> (ø)
src/Polly.Core/Outcome.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Outcome.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceProperties.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryConstants.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryDelayGeneratorArguments.cs 100.00% <ø> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) August 30, 2023 08:37
@martintmk martintmk merged commit 58c8fac into main Aug 30, 2023
11 of 12 checks passed
@martintmk martintmk deleted the mtomka/fix-delay branch August 30, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants