Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the telemetry tags with official guidelines #1583

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 13, 2023

Details on the issue fix or feature implementation

dotnet/extensions#4373 (comment)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 13, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6e69ec3) 83.99% compared to head (5fe701d) 83.99%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1583   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         280      280           
  Lines        6548     6548           
  Branches     1020     1020           
=======================================
  Hits         5500     5500           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 83.99% <100.00%> (?)
macos 83.99% <100.00%> (ø)
windows 83.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...olly.Extensions/Telemetry/TelemetryListenerImpl.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit e76b01d into main Sep 21, 2023
18 checks passed
@martintmk martintmk deleted the mtomka/allign-tags branch September 21, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant