[Docs] General extensibility and implementation of proactive strategies #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6820 6820
Branches 1044 1044
=======================================
Hits 5772 5772
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamnova
reviewed
Sep 20, 2023
| public TimingStrategyOptions() | ||
| { | ||
| // It's recommended to set the default name for the options so | ||
| // the consumer can get additional information in the telemetry. |
There was a problem hiding this comment.
What additional information? If it's just the name I would probably say "the consumer can see it in the telemetry" if it allows access to more things, an example could be handy to help build a picture.
There was a problem hiding this comment.
Reworded slightly.
adamnova
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Contributes to #1091
Confirm the following