Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHA256 for ChecksumAlgorithm and fix Binskim warning #1623

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 25, 2023

The issue or feature being addressed

Closes #1617

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (45b0bde) 84.65% compared to head (8c27f30) 84.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1623   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         306      306           
  Lines        6829     6829           
  Branches     1045     1045           
=======================================
  Hits         5781     5781           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.65% <ø> (ø)
windows 84.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Would be good to run binskim on the binaries from the build before merging to check it resolves the reported warning.

@martintmk
Copy link
Contributor Author

LGTM - Would be good to run binskim on the binaries from the build before merging to check it resolves the reported warning.

Looks good:

C:\Development\GitHub\Polly\src\Polly.Core\bin\Debug\net6.0\Polly.Core.dll: pass BA2004: 'Polly.Core.dll' is a managed binary which was compiled with a secure (SHA-256) source code hashing algorithm.

@martintmk martintmk enabled auto-merge (squash) September 25, 2023 08:12
@martintmk martintmk merged commit 2759971 into main Sep 25, 2023
14 checks passed
@martintmk martintmk deleted the mtomka/use-sha256 branch September 25, 2023 08:12
@martincostello martincostello added this to the v8.0.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix Binskim warning
2 participants