#1687 - Make ResilienceContextPool settable via DI #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.02%
==========================================
Files 306 306
Lines 6819 6829 +10
Branches 1045 1046 +1
==========================================
+ Hits 5771 5781 +10
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
test/Polly.Core.Tests/Utils/Pipeline/CompositePipelineComponentTests.cs
Outdated
Show resolved
Hide resolved
martintmk
reviewed
Oct 12, 2023
martintmk
reviewed
Oct 13, 2023
martintmk
approved these changes
Oct 16, 2023
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
cmeyertons
force-pushed
the
feature/resilience-pool-settable
branch
from
e64f532
to
a4899d7
Compare
|
@martincostello @martintmk changes should be good to go from my end -- rebased off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1687
Details on the issue fix or feature implementation
Followed @martintmk suggestion to make
ResilientContextPoolsettable via DI pipelineConfirm the following