-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Make quick start samples consistent #1735
[Docs] Make quick start samples consistent #1735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 307 307
Lines 6790 6790
Branches 1043 1043
=======================================
Hits 5742 5742
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion.
Co-authored-by: Martin Costello <martin@martincostello.com>
Pull Request
The issue or feature being addressed
Details on the issue fix or feature implementation
Mitigation
andPrevention
respectivelystatic
anonymous function where it was possiblenew()
instead of the full name of theXYZStrategyOptions
.Build()
calls for the sake of consistencyConfirm the following