Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component benchmark #1743

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

martincostello
Copy link
Member

  • Add a benchmark for CompositeComponent to aid with [Feature request]: AOT compatibility #1732.
  • Use MSBuild built-in support for [InternalsVisibleTo] public key.
  • Rename item so it can be used in projects that aren't tests (i.e. the benchmarks) without an incorrect name.
  • Make it easier to build without strong naming if needed.
  • Make conditions a bit more readable.
  • Sort properties.

- Use MSBuild built-in support for `[InternalsVisibleTo]` public key.
- Rename item so it can be used in projects that aren't tests without an incorrect name.
- Make it easier to build without strong naming.
- Make conditions a bit more readable.
- Sort properties.
Allow `[InternalsVisibleTo]` for the Polly.Core benchmarks.
Add a benchmark for `CompositeComponent` to aid with App-vNext#1732.
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95b217b) 84.56% compared to head (3e4656b) 84.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1743   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         307      307           
  Lines        6790     6790           
  Branches     1043     1043           
=======================================
  Hits         5742     5742           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.56% <ø> (ø)
macos 84.56% <ø> (ø)
windows 84.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.1.0 milestone Oct 28, 2023
@martincostello martincostello added the aot Relates to native AoT support label Oct 28, 2023
@martincostello martincostello merged commit a0e30b0 into App-vNext:main Oct 28, 2023
18 checks passed
@martincostello martincostello deleted the add-component-benchmark branch October 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aot Relates to native AoT support CI/build performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants