Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add diagram about hedging's context and callbacks #1751

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 30, 2023

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • As it was discussed in the review comments: it makes sense to visualize the sequence of actions related to context and callbacks
  • @martintmk Can you please double check whether the diagram depicts everything and in the right order?
  • Preview

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41d4e8d) 84.56% compared to head (fb30254) 84.56%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         307      307           
  Lines        6790     6790           
  Branches     1043     1043           
=======================================
  Hits         5742     5742           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.56% <ø> (ø)
macos 84.56% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/strategies/hedging.md Outdated Show resolved Hide resolved
docs/strategies/hedging.md Outdated Show resolved Hide resolved
@martintmk
Copy link
Contributor

Some real-case scenario where this is used:

https://github.com/dotnet/extensions/blob/3038d565967654ffb92cdd5edf434930c9249e91/src/Libraries/Microsoft.Extensions.Http.Resilience/Hedging/ResilienceHttpClientBuilderExtensions.Hedging.cs#L84

@martintmk martintmk enabled auto-merge (squash) October 30, 2023 12:38
@martintmk martintmk merged commit e94c828 into App-vNext:main Oct 30, 2023
14 checks passed
@peter-csala peter-csala deleted the add-sequence-diagram-about-hedgings-contexts-and-callbacks branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants