Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace growing for opened circuit breaker #1878

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 2, 2024

Pull Request

The issue or feature being addressed

#1877

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martincostello martincostello added this to the v8.3.0 milestone Jan 2, 2024
@martintmk martintmk force-pushed the mtomka/cb-stack-trace branch from af8d45a to 372cecb Compare January 3, 2024 08:13
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (502094f) 84.62% compared to head (bc433bb) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1878   +/-   ##
=======================================
  Coverage   84.62%   84.63%           
=======================================
  Files         309      309           
  Lines        6818     6820    +2     
  Branches     1050     1050           
=======================================
+ Hits         5770     5772    +2     
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <100.00%> (+<0.01%) ⬆️
macos 84.63% <100.00%> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) January 3, 2024 09:02
@martintmk martintmk merged commit b145338 into main Jan 3, 2024
14 checks passed
@martintmk martintmk deleted the mtomka/cb-stack-trace branch January 3, 2024 09:03
@martincostello martincostello modified the milestones: v8.3.0, v8.2.1 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants