Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1602/S6608/S4144 warnings #1936

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

gintsk
Copy link
Contributor

@gintsk gintsk commented Jan 27, 2024

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Fix SA1602
Fix S6608 (net481 style)
Fix S4144 (remove duplicate tests)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@gintsk
Copy link
Contributor Author

gintsk commented Jan 27, 2024

@dotnet-policy-service agree

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martincostello martincostello enabled auto-merge (squash) January 27, 2024 16:28
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19b5e73) 84.81% compared to head (317b244) 84.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         312      312           
  Lines        6900     6900           
  Branches     1056     1056           
=======================================
  Hits         5852     5852           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.81% <ø> (ø)
macos 84.81% <ø> (ø)
windows 84.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 0719338 into App-vNext:main Jan 27, 2024
14 checks passed
@gintsk gintsk deleted the cleanup branch January 27, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants