Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1501/IDE0055 #1957

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

baranyaimate
Copy link
Contributor

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Fix SA1501 and IDE0055.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martincostello
Copy link
Member

Thanks for the PR - to merge this, either unit tests need to be added to improve the coverage, or the coverage baselines need to be adjusted to account for all the additional lines of code that are not covered now that all the checks have been expanded to two lines instead of one.

@baranyaimate
Copy link
Contributor Author

Thank you for your review and feedback! I will add more unit tests to achieve the necessary coverage.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 569 lines in your changes are missing coverage. Please review.

Comparison is base (b194abf) 85.90% compared to head (8df1a25) 83.23%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Polly/Retry/AsyncRetryTResultSyntax.cs 9.43% 48 Missing and 48 partials ⚠️
src/Polly/Retry/AsyncRetrySyntax.cs 20.90% 43 Missing and 44 partials ⚠️
src/Polly/Retry/RetryTResultSyntax.cs 11.76% 30 Missing and 30 partials ⚠️
src/Polly/Caching/AsyncCacheTResultSyntax.cs 11.11% 16 Missing and 16 partials ⚠️
src/Polly/Caching/CacheTResultSyntax.cs 11.11% 16 Missing and 16 partials ⚠️
src/Polly/Retry/RetrySyntax.cs 60.52% 15 Missing and 15 partials ⚠️
src/Polly/Timeout/AsyncTimeoutTResultSyntax.cs 30.00% 10 Missing and 11 partials ⚠️
src/Polly/Context.Dictionary.cs 9.09% 20 Missing ⚠️
src/Polly/Caching/AsyncCacheSyntax.cs 25.00% 9 Missing and 9 partials ⚠️
src/Polly/Caching/CacheSyntax.cs 25.00% 9 Missing and 9 partials ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   85.90%   83.23%   -2.67%     
==========================================
  Files         312      312              
  Lines        6647     7106     +459     
  Branches     1056     1056              
==========================================
+ Hits         5710     5915     +205     
- Misses        540      806     +266     
+ Partials      397      385      -12     
Flag Coverage Δ
linux 83.23% <41.27%> (-2.67%) ⬇️
macos 83.23% <41.27%> (-2.67%) ⬇️
windows 83.23% <41.27%> (-2.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.3.1 milestone Feb 16, 2024
@martincostello martincostello merged commit 5fe3377 into App-vNext:main Feb 16, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants