Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3800/CA1821/S2955 #2020

Merged

Conversation

baranyaimate
Copy link
Contributor

@baranyaimate baranyaimate commented Mar 17, 2024

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Fix S3800, CA1821 and S2955.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.67%. Comparing base (197cc16) to head (9403059).

Files Patch % Lines
src/Polly/Policy.HandleSyntax.cs 50.00% 0 Missing and 1 partial ⚠️
src/Polly/PolicyBuilder.OrSyntax.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
+ Coverage   83.64%   83.67%   +0.02%     
==========================================
  Files         312      312              
  Lines        7105     7105              
  Branches     1054     1054              
==========================================
+ Hits         5943     5945       +2     
  Misses        789      789              
+ Partials      373      371       -2     
Flag Coverage Δ
linux 83.67% <50.00%> (+0.02%) ⬆️
macos ?
windows 83.67% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit f99a4ce into App-vNext:main Mar 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants