Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fixes from .NET 9 testing #2056

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

martincostello
Copy link
Member

Port various changes/fixes from #2003 that don't depend on .NET 9.

  • Fix IDE0057 warnings.
  • Suppress xUnit1031 warnings in tests that explicitly test synchronous behaviours.
  • Remove properties that are implied by IsAotCompatible=true.
  • Only mark as AoT-compatible for net8.0 where it's actually supported.
  • Fix test not being declared in a namespace.
  • Bump the samples' reference to ourself to the latest version.
  • Bump Microsoft.Extensions.TimeProvider.Testing to 8.4.0.
  • Use an MSBuild property to allow for easy conditions for multi-targeting.

Fix IDE0057 warnings identified in App-vNext#2003.
Suppress xUnit1031 warnings in tests that explicitly test synchronous behaviours.
- Remove properties that are implied by `IsAotCompatible=true`.
- Only mark as AoT-compatible for `net8.0` where it's actually supported.
Fix test not being declared in a namespace.
- Bump the samples' reference to ourself to the latest version.
- Bump `Microsoft.Extensions.TimeProvider.Testing` to 8.4.0.
- Use an MSBuild property to allow for easy conditions for multi-targeting.
@martincostello martincostello added enhancement CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code aot Relates to native AoT support labels Apr 12, 2024
@martincostello martincostello added this to the v8.3.2 milestone Apr 12, 2024
Add package reference to Microsoft.Bcl.TimeProvider as Microsoft.Extensions.TimeProvider.Testing appears to have trimmed the dependency away.
Add `VersionOverride` to fix package downgrade warning.
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (9ccc6c6) to head (71fcef2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2056   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         312      312           
  Lines        7105     7106    +1     
  Branches     1054     1054           
=======================================
+ Hits         5945     5946    +1     
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.67% <100.00%> (+<0.01%) ⬆️
macos 83.67% <100.00%> (+<0.01%) ⬆️
windows 83.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review April 12, 2024 09:44
@martincostello martincostello merged commit 4f67189 into App-vNext:main Apr 12, 2024
18 checks passed
@martincostello martincostello deleted the port-fixes branch April 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aot Relates to native AoT support CI/build dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants