Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the Polly and Polly.Specs codebase #2467

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Cleanup the Polly and Polly.Specs codebase #2467

merged 10 commits into from
Jan 28, 2025

Conversation

martincostello
Copy link
Member

  • Suppress extant occurences of code analysis warnings inline in the code and re-enable suppressed rules.
  • Fix remaining IDE/formatting suggestions in Polly.Specs.

Resolves #1290.

Apply remaining IDE suggestions for code simplification and clean-up in Polly.Specs.
- Suppress occurrences of S3215.
- Re-enable the S3215 rule.
- Suppress extant occurrences of S2223.
- Re-enable S2223.
- Suppress extant occurrences of CA1051.
- Enable CA1051.
- Suppress extant occurrences of CA1724.
- Re-enable CA1724.
- Suppress extant occurrence of CA1064.
- Re-enable CA1064.
- Suppress extant occurrences of CA1031.
- Re-enable CA1031.
- Suppress extant occurrences of CA1063.
- Re-enable CA1063.
Add missing CA1063 suppressions.
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (7148503) to head (ab4d596).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2467   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         312      312           
  Lines        7464     7465    +1     
  Branches     1121     1121           
=======================================
+ Hits         6371     6372    +1     
  Misses        908      908           
  Partials      185      185           
Flag Coverage Δ
linux 85.35% <100.00%> (+<0.01%) ⬆️
macos 85.35% <100.00%> (+<0.01%) ⬆️
windows 85.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix IDE0055 warnings on Windows.
@martincostello martincostello marked this pull request as ready for review January 28, 2025 10:54
@martincostello martincostello enabled auto-merge (rebase) January 28, 2025 10:54
@martincostello martincostello merged commit 7d4bfd8 into main Jan 28, 2025
24 checks passed
@martincostello martincostello deleted the gh-1290 branch January 28, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the Polly and Polly.Specs codebase
1 participant