Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Linux and macOS #996

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

martincostello
Copy link
Member

The issue or feature being addressed

Add CI build for Linux and macOS.

Contributes to #980.

Details on the issue fix or feature implementation

  • Update the build.ps1 script to support running on non-Windows platforms.
  • Build on Linux and macOS in GitHub Actions.
  • Remove redundant parameters from build.ps1.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

- Update the build.ps1 script to support running on non-Windows platforms.
- Build on Linux and macOS in GitHub Actions.
- Remove redundant parameters from `build.ps1`.
Remove `netcoreapp3.1` from the tests as it is now out of support and also isn't installed by default on Linux in GitHub Actions.
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #996 (18528b8) into main (d3c4e1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         137      137           
  Lines        3768     3768           
  Branches      764      764           
=======================================
  Hits         2682     2682           
  Misses        875      875           
  Partials      211      211           
Flag Coverage Δ
linux 71.17% <ø> (?)
macos 71.17% <ø> (?)
windows 71.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Use `GitVersion.Tool` instead of `GitVersion.CommandLine` so it works on Linux and macOS.
@martincostello martincostello marked this pull request as ready for review January 6, 2023 23:11
@martincostello martincostello merged commit 977f3e1 into App-vNext:main Jan 6, 2023
@martincostello martincostello deleted the xplat-ci branch January 6, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants