Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: automatic build #1666

Merged
merged 2 commits into from
Feb 28, 2023
Merged

CI: automatic build #1666

merged 2 commits into from
Feb 28, 2023

Conversation

mion00
Copy link
Contributor

@mion00 mion00 commented Feb 28, 2023

Automatically build the Docker container and the Python package.

Description

  • On pull requests against dev -> build Python package and the Docker image, but don't publish them.
  • When there is a push in the dev branch -> build Docker image with tag dev, deploy to Docker Hub
  • When there is a git tag, build Docker image with tag taken from version + deploy to Docker Hub and PyPi.

TODO

How to handle version numbering for the Python package? Should we use the Git tag to automatically infer the package version?
That way we don't have to manually update the version.py file every time we have a release, risking a mismatch between the tag and the version written inside if one forgets to keep them in sync.

Requirements

Setup Github secrets inside the repository settings with the credentials to authenticate against PyPI and Docker Hub
Secrets needed:

On PR against `dev` build the Python package and the Docker image.
If there is push in the `dev` branch or a git tag, also deploy to Docker Hub and PyPi.
@acockburn
Copy link
Member

acockburn commented Feb 28, 2023 via email

@acockburn acockburn merged commit 35f92d7 into AppDaemon:dev Feb 28, 2023
@mion00 mion00 deleted the ci/automatic_build branch March 1, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants