Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear selection extra info before inserting a new line #1009

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Dec 30, 2024

Clear the selection's extra info before inserting a new line to prevent the text input service from failing to attach.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (1f124c1) to head (55aa405).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   71.96%   71.97%   +0.01%     
==========================================
  Files         319      319              
  Lines       15312    15318       +6     
==========================================
+ Hits        11019    11025       +6     
  Misses       4293     4293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 force-pushed the clear_selection_info branch from abf124e to 45a1d88 Compare December 30, 2024 07:17
@LucasXu0 LucasXu0 force-pushed the clear_selection_info branch from 45a1d88 to 55aa405 Compare December 30, 2024 07:27
@LucasXu0 LucasXu0 merged commit cfb8b1b into AppFlowy-IO:main Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant