Handle verbosity in extract_appimage for non-returning errors (#1233) #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoxolotl
commented
Sep 2, 2023
| @@ -361,7 +361,9 @@ bool extract_appimage(const char* const appimage_path, const char* const _prefix | |||
| } else { | |||
| struct stat st; | |||
| if (!overwrite && stat(prefixed_path_to_extract, &st) == 0 && st.st_size == inode.xtra.reg.file_size) { | |||
| fprintf(stderr, "File exists and file size matches, skipping\n"); | |||
| if (verbose) { | |||
| fprintf(stderr, "File exists and file size matches, skipping\n"); | |||
There was a problem hiding this comment.
This is the only place where I am checking for verbose flag. The other fprintfs were being called before a return so I thought it'd be unwise for verbose == False to block them. Can add in if required.
|
Thanks @aoxolotl. Since we will be switching to https://github.com/AppImage/type2-runtime soon, you might want to send a PR there as well. Thanks! |
|
Thanks for the review! Can look into type-2 runtime as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if verbose flag is set for
fprintf("File exists and file size matches, skipping".). Fixes #1233