Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vircadia #2470

Merged
merged 19 commits into from
Oct 10, 2021
Merged

Add Vircadia #2470

merged 19 commits into from
Oct 10, 2021

Conversation

JulianGro
Copy link
Contributor

No description provided.

@probonopd
Copy link
Member

probonopd commented May 1, 2021

unable to resolve host address ‘appimage.moto9000.moe’

Is that the correct address?
Please upload the AppImage to https://github.com/vircadia/vircadia/releases, then we can use that. Thanks!

@JulianGro
Copy link
Contributor Author

@probonopd The address is correct and works fine on my network.
Could you try rerunning it?

@probonopd
Copy link
Member

probonopd commented May 1, 2021

At the time when I tested it it did not work, also on my local machine. (Now it does - but how long before it goes down again?)

I see that the domain is linked from https://vircadia.com/download-vircadia/#linux - so I think we can consider it trusted by the project.

@JulianGro
Copy link
Contributor Author

What DNS are you using?

@probonopd
Copy link
Member

Whtever my provider provides ;-) now it is working btw.

@probonopd
Copy link
Member

probonopd commented May 1, 2021

There is a permissions issue with the AppImage:
/bin/bash: /run/firejail/appimage/.appimage-11546/AppRun: Permission denied

Looks similar to #2102.
Please make sure that the top-level directory is readable by everyone.

Reference:
netblue30/firejail#2690

@JulianGro
Copy link
Contributor Author

JulianGro commented May 1, 2021

Yeah I am not sure if it makes sense for me to extract the AppImages and manually sqash them for every update.
Seems like this should be fixed in appimagetool instead.

EDIT: the test to see if it's the problem doesn't work btw.

motofckr9k@motofckr9k-mint-desktop:~/git$ unsquashfs -ll Vircadia-x86_64-release-latest.AppImage /
Can't find a SQUASHFS superblock on Vircadia-x86_64-release-latest.AppImage
motofckr9k@motofckr9k-mint-desktop:~/git$ 

I just ran it instead and looked at my /tmp/ folder.

@probonopd
Copy link
Member

probonopd commented May 2, 2021

the test to see if it's the problem doesn't work btw.

You need to provide the correct offset to unsquashfs, with you can get by running ./Vircadia-x86_64-release-latest.AppImage --appimage-offset.

@probonopd
Copy link
Member

/bin/bash: /run/firejail/appimage/.appimage-11660/AppRun: Permission denied

@JulianGro
Copy link
Contributor Author

/bin/bash: /run/firejail/appimage/.appimage-11660/AppRun: Permission denied

This is still a bug in AppImageKit AppImage/AppImageKit#1032
I am not up for manually unpacking and repacking the AppImage for every update if it works for all end-users.

@JulianGro
Copy link
Contributor Author

Yeah it looks like the virtual graphics adapter doesn't support the minimum required OpenGL version or even the minimum OpenGL ES version needed for a mobile build, so this will never run properly.
I assume if it creates a screenshot it is either a black window or a black window with the toolbar showing on the bottom.

@probonopd
Copy link
Member

Warning: :04:43] [WARNING] [hifi.gpu.gl] GLBackend::compileBackendProgram - Shader didn't compile:
Warning: :04:43] [WARNING] [hifi.gpu.gl]  0:1(10): error: GLSL 4.10 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, 1.50, 3.30, 1.00 ES, and 3.00 ES
Warning: :04:43] [WARNING] [hifi.gpu.gl] 
Warning: :04:43] [WARNING] [hifi.gpu.gl] GLBackend::compileBackendProgram - One of the shaders of the program is not compiled?

Our test machine has no actual GPU. How can we still take a screenshot?

@JulianGro
Copy link
Contributor Author

You cannot. Like I said, you will get a black window. If you are lucky it will show you the toolbar.

I tried adding AppStream information with screenshots in the past, but apparently that isn't as easy as it seems: AppImage/AppImageKit#603

@JulianGro
Copy link
Contributor Author

JulianGro commented Jul 12, 2021

Then again, if it passing the tests would be good enough for you to include it, then we can just have it have a broken screenshot until AppImage/AppImageKit#603 is fixed.
That would be next Vircadia release though since this is only an experimental AppImage.

@probonopd
Copy link
Member

https://appimage.github.io/simple-appstream-generator/ is my answer to #603 - does it work for you?

@JulianGro
Copy link
Contributor Author

No. I run into exactly the same issue as descripbed in the opening post of AppImage/AppImageKit#603

@probonopd
Copy link
Member

Remove appstream-util from your system and retry, please.

@JulianGro
Copy link
Contributor Author

Seems to have worked. It should make it into the next release.

JulianGro and others added 4 commits July 12, 2021 10:25
@JulianGro
Copy link
Contributor Author

Almost forgot about this.
@probonopd the latest release should be perfectly fine to merge now.

@probonopd
Copy link
Member

Is it really just showing a black screen when not connected to the internet?

image

@JulianGro
Copy link
Contributor Author

Is it really just showing a black screen when not connected to the internet?

@probonopd No it is showing a black screen when on a machine that doesn't support proper OpenGL. That is one of the reasons there are screenshots in the AppStream.
When first starting the app you spawn in a "serverless tutorial" which doesn't need a connection to the internet.

@JulianGro
Copy link
Contributor Author

Is there anything keeping this up?
Like is there issues with using screenshots from AppStream currently?

@probonopd
Copy link
Member

probonopd commented Oct 10, 2021

Does it no longer show a black screen when the computer is offline? That is required for the test to be considered a "pass".

@JulianGro
Copy link
Contributor Author

It doesn't show a blackscreen when the computer is offline.
It only shows a blackscreen because your test doesn't support OpenGL 4.1 or higher.

@probonopd probonopd merged commit cf5610e into AppImage:master Oct 10, 2021
@probonopd
Copy link
Member

https://appimage.github.io/Vircadia/ :)

This was referenced Oct 10, 2021
@JulianGro JulianGro mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants