Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Ubuntu without Docker for the sake of documentation #241

Closed
wants to merge 16 commits into from

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented Nov 25, 2024

Everything in one yml file for ease of understanding. No Docker.

For #239

@probonopd probonopd changed the title Build on Ubuntu Build on Ubuntu without Docker for the sake of documentation Nov 25, 2024
@probonopd probonopd marked this pull request as draft November 25, 2024 20:20
@probonopd
Copy link
Member Author

Probably more shenanigans from https://github.com/AppImageCommunity/AppImageUpdate/blob/main/ci/Dockerfile.x86_64 are needed...

@TheAssassin
Copy link
Member

TheAssassin commented Nov 26, 2024

This is pointless, redundant and ultimately unnecessary. I wouldn't want to maintain this. It wastes resources with a superfluous unsupported build job. It does not provide any benefit for the community. See #239.

Edit: there's so much to say about this PR. You are doing a lot of unnecessary work given the fact that the binaries are built statically anyway. But then again, as said, this is pointless. I suggest you have a look at the upcoming commits for informational purposes. There's no point in such a contribution.

@probonopd
Copy link
Member Author

probonopd commented Nov 26, 2024

Even if we end up not merging this, I'd like to document how to build this without Docker. And I am (ab)using this PR to get builds done in a documented way (as opposed to a local dev machine).

Not sure whether GitHub Actions runs on closed PRs, so I am (temporarily) reopening this. Once the research has been completed (build succeeds), the gained insights can be transferred to the md and this PR can be closed again.)

@probonopd probonopd reopened this Nov 26, 2024
@probonopd
Copy link
Member Author

This has now served its intended purpose; the results are in

@probonopd probonopd closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants