Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed correct handling of OBS repositories as debian source #550

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

csoler
Copy link
Contributor

@csoler csoler commented Jan 7, 2024

Took me a while to find this, but according to the pkg2appimage documentation, Debian repositories from the opensuse build system should be listed as:

dist: [ubuntu distrib]
sources:

...but in functions.sh, the parsing method employed in apt-get.update() is only compatible with the classical syntax such as

...so it fails and doesn't fill the Packages.gz file.
The present patch solves this (probably not very elegantly).

@probonopd
Copy link
Member

Thanks @csoler. How do you test this?

@csoler
Copy link
Contributor Author

csoler commented Jan 13, 2024

You just need to do this: pkg2appimage ./retroshare.yml
The file retroshare.yml is pasted below.
Also I found out that the current functions.sh doesn't actually select the latest package on OBS, probably because packages are not necessarily listed by version number, so it takes the first one in the list. If you use the patch above, you'll get a Retroshare appimage for 0.6.6. In order to force the package version, I implemented a way to specify it in the yml as
packages:
- retroshare-common=0.7.6-1
- [...]
I'll add the commit below. I totally understand if you'd prefer to to include this commit, since it adds additional syntax to yml files (yet perfectly keeps backward compatibility).

@csoler
Copy link
Contributor Author

csoler commented Jan 13, 2024

note that another way to go would be to fix the automated selection of latest versions of packages from OBS in functions.sh. I opted for specifying the version, as it's probably more handy. Both may be implemented of course. The retroshare.yml is attached below.
yml_file.zip

@probonopd probonopd merged commit d80bb13 into AppImageCommunity:master Jan 16, 2024
1 check passed
@probonopd
Copy link
Member

Thanks @csoler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants