Fix double event emission on contract tx simulation

src/contract/contractmanager.cpp

@@ -189,29 +189,34 @@ bool ContractManager::validateCallContractWithTx(const ethCallInfo& callInfo) {
       this->callLogger_->setContractVars(this, from, from, value);
       this->ethCall(callInfo);
       this->callLogger_.reset();
+      this->eventManager_.revertEvents();
       return true;
     }
 
     if (to == ProtocolContractAddresses.at("rdPoS")) {
       this->callLogger_->setContractVars(&rdpos_, from, from, value);
       rdpos_.ethCall(callInfo);
       this->callLogger_.reset();
+      this->eventManager_.revertEvents();
       return true;
     }
 
     std::shared_lock<std::shared_mutex> lock(this->contractsMutex_);
     if (!this->contracts_.contains(to)) {
       this->callLogger_.reset();
+      this->eventManager_.revertEvents();
       return false;
     }
     const auto &contract = contracts_.at(to);
     this->callLogger_->setContractVars(contract.get(), from, from, value);
     contract->ethCall(callInfo);
   } catch (std::exception &e) {
     this->callLogger_.reset();
+    this->eventManager_.revertEvents();
     throw DynamicException(e.what());
   }
   this->callLogger_.reset();
+  this->eventManager_.revertEvents();
   return true;
 }
 

src/contract/contractmanager.h

@@ -460,7 +460,6 @@ class ContractManagerInterface {
       // inside contracts and are not emitted if a transaction reverts.
       // C++ itself already takes care of events not being emitted on pure/view
       // functions due to its built-in const-correctness logic.
-      // TODO: check later if events are really not emitted on transaction revert
       if (!this->manager_.callLogger_) throw DynamicException(
         "Contracts going haywire! Trying to emit an event without an active contract call"
       );

tests/sdktestsuite.hpp

@@ -469,7 +469,7 @@ class SDKTestSuite {
       );
       ret = tx.hash();
       // Check if the execution is not going to be reverted/throw
-      this->state_.estimateGas(tx.txToCallInfo()); // TODO: this is emitting duplicate events, needs to be fixed
+      this->state_.estimateGas(tx.txToCallInfo());
       this->advanceChain(timestamp, {tx});
       return ret;
     }