Netp2p refactor #105
Merged
Netp2p refactor #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NodeConns is now a component of ManagerNormal - Finished BroadcastInfo (but it will probably will be removed/useless) - Added Notify/Notification as a new P2P message type - Added NotifyInfo - Added NodeConns worker thread (100ms info refresh, 10s timeout) - NodeConns worker thread lifetime tied to ManagerNormal start()/stop() - Old code is now NodeConns::forceRefresh() (synchronous NodeInfo refresh) NOTE: There are test failures.
- Implemented simple syncer loop that will run on boot - Added a simple 2-node P2P unit test for the Syncer TODO: - Need to ensure connectivity is sufficient before Syncer::sync() is called by the main thread on node boot; this was not tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.