Implement GC of ManagerBase::requests_ #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of REQUEST_BUCKET_SIZE_LIMIT requests at any given time.
Jean-Lessa
approved these changes
Dec 20, 2024
Pedrozo
approved these changes
Dec 20, 2024
src/net/p2p/managerbase.h
Outdated
| /// Size of a sync-requests active bucket, in items (requests); there are two buckets. | ||
| /// This needs to be large enough to hold the maximum number of requests that can be conceivable generated | ||
| /// in the maximum time period that it takes to answer a request. | ||
| #define REQUEST_BUCKET_SIZE_LIMIT 100000 |
There was a problem hiding this comment.
What do you think about this?
constexpr size_t REQUEST_BUCKET_SIZE_LIMIT = 100'000;
src/net/p2p/managerbase.h
Outdated
| * Insert a new request into requests_. | ||
| * @param request The newly created request to be tracked by requests_. | ||
| */ | ||
| void insertRequest(const std::shared_ptr<Request>& request); |
There was a problem hiding this comment.
Since this function intends to take ownership of the std::shared_ptr copy, it would be a little bit better to receive it by value instead of const-ref.
Like that:
void insertRequest(std::shared_ptr<Request> request) {
requests_[activeRequests_][request->id()] = std::move(request); // note the move
// ...
}Moving a shared_ptr is cheaper than copying it. At least in this way, you delegate to the caller the decision of copying or moving it (instead of always copying).
I'd suggest also making such change in other places too, where a std::shared_ptr parameter is received and will be stored somewhere, but such change could fall out of the scope of this PR. No problem at all if you decide not to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net: limit the number of requests tracked by keeping only a minimum of REQUEST_BUCKET_SIZE_LIMIT (currently 100,000) requests at any given time.