Internal refactor of P2P::Session vs. P2P::ManagerXXX classes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
12.6% Coverage on New Code
21.4% Duplication on New Code
- Rule out any possibility that ManagerBase::sessions_ will grow (or shrink) after ManagerBase::close_ is set to true, so that ManagerBase::stop() can close all registered sessions - On ManagerBase::stop(), join the Session thread pool after Server and ClientFactory are stopped (possibly more correct)
- removed closed_; replaced by started_ (ManagerBase should be able to start() and stop() repeatedly and safely) - added stateMutex_ to synchronize start(), stop() and thread pool - start() creates threadPool_ - stop() destroys threadPool_ (waits for all tasks and joins all threads, guaranteeing that there is no session/socket message handling code active when it is time to e.g. destroy the underlying io_context) - threadPool_ is now isolated and not forwarded to other objects; to use the ManagerBase thread pool, other objects have to call a method on ManagerBase that will service the request, such as ManagerBase::asyncHandleMessage() state.cpp (test): - increased timeout from 5s to 120s in a couple of futures to avoid random, performance-related failures (logs to cout if they exceed 5s, which in any case is rare)
jcarraror
approved these changes
Feb 22, 2024
itamarcps
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
std::weak_ptr<Session>argument inP2P::ManagerXXXAPIs toNodeIdinstead, which induces an additional lookup for the Session object from that NodeId.I'm also including some changes to the P2P::ManagerBase start / stop.