Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for config is present instead of DEBUG flag (docker is in RELEASE) #15

Merged
merged 1 commit into from
Mar 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions emails/Services/EmailService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@
};
}

public async Task<SendResponse?> SendEmailAsync<T>(string emailTo, string subject, T model, string templateName)

Check warning on line 25 in emails/Services/EmailService.cs

View workflow job for this annotation

GitHub Actions / build

Nullability of reference types in return type of 'Task<SendResponse?> EmailService.SendEmailAsync<T>(string emailTo, string subject, T model, string templateName)' doesn't match implicitly implemented member 'Task<SendResponse> IEmailService.SendEmailAsync<T>(string emailTo, string subject, T model, string templateName)'.
{
logger.LogInformation($"Sending email to {emailTo} with subject {subject} and template {templateName}");

#if DEBUG
emailTo = settings.ToWhenDebugging;
#endif
if (!string.IsNullOrEmpty(settings.ToWhenDebugging))
emailTo = settings.ToWhenDebugging;

var email = Email
.From(settings.From)
Expand Down
Loading