PS-148 notification email #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MysticFragilist
commented
Apr 8, 2024
•
MysticFragilist
commented
camillebrulotte
suggested changes
Apr 8, 2024
HugoMigner
reviewed
Apr 8, 2024
| var notifService = (serviceScope.ServiceProvider?.GetService<INotificationService>()) ?? throw new SchedulerException("Cannot instantiate NotificationService from the AspNet Core IOC."); | ||
|
|
||
| var emailsCount = await notifService.SendNewsForRemainingPublication(); | ||
| await Console.Out.WriteLineAsync($"[NotificationByEmailJob] {emailsCount} emails were sent out"); |
There was a problem hiding this comment.
Ça c'est tu nécessaire? 😮
There was a problem hiding this comment.
Ouii pour logger des info! Mais tu me fais penser que c'est mieux de use le logger provided
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
MysticFragilist
commented
Apr 10, 2024
…ckend-Hello into ftr/ps-148-notification-email
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.