Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBSD support #620

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add FreeBSD support #620

merged 1 commit into from
Jan 13, 2022

Conversation

rozhuk-im
Copy link
Contributor

Add FreeBSD support and probably fix other OSes to not show network interfaces without BROADCAST flag.

@EmmanuelP EmmanuelP marked this pull request as draft January 11, 2022 13:41
@EmmanuelP
Copy link
Contributor

Hi.

Thanks for the pull request. Unfortunately it seems to break the build on macOS and MSVC, and introduce a crash in the fakegv test.

@EmmanuelP EmmanuelP added the 5. Gige Issue in the GigEVision implementation label Jan 11, 2022
@rozhuk-im
Copy link
Contributor Author

Have no idea why Linux and MSVC fail, looks like some temporary errors in test system.

@rozhuk-im rozhuk-im force-pushed the fbsd branch 2 times, most recently from 7f78e37 to f73b071 Compare January 11, 2022 20:09
@rozhuk-im
Copy link
Contributor Author

After I disable if ((ifap_iter->ifa_flags & IFF_BROADCAST) == 0) test is passed, but IMHO this is wrong, and interfaces without broadcast flag must not be used.

@rozhuk-im rozhuk-im marked this pull request as ready for review January 11, 2022 22:16
EmmanuelP
EmmanuelP requested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@EmmanuelP EmmanuelP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Once the commented code is removed, it will be ready to merge.

src/arvnetwork.c Outdated Show resolved Hide resolved
@EmmanuelP
Copy link
Contributor

After I disable if ((ifap_iter->ifa_flags & IFF_BROADCAST) == 0) test is passed, but IMHO this is wrong, and interfaces without broadcast flag must not be used.

That is not really related to the main goal of this pull request, so the pull request can be merged without this part. But feel free to investigate why this test makes the fakegv test fail on linux and macOS in another pull request.

@rozhuk-im rozhuk-im requested a review from EmmanuelP January 13, 2022 03:39
EmmanuelP
EmmanuelP requested changes Jan 13, 2022
View reviewed changes
src/arvnetworkprivate.h Show resolved Hide resolved
@rozhuk-im rozhuk-im requested a review from EmmanuelP January 13, 2022 07:43
@EmmanuelP EmmanuelP merged commit cb27eb4 into AravisProject:main Jan 13, 2022
@EmmanuelP
Copy link
Contributor

Thanks a lot.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Feb 17, 2022
@rozhuk-im @fernape
devel/libaravis: multimedia/aravis: update to 0.8.20
7d0f2b0 
ChangeLog: AravisProject/aravis#620

PR:	261103
Reported by:	rozhuk.im@gmail.com (maintainer)
Reviewed by:	diizzy@
5u623l20 pushed a commit to 5u623l20/freebsd-ports that referenced this pull request Feb 19, 2022
@rozhuk-im
devel/libaravis: multimedia/aravis: update to 0.8.20
d5d1ea5 
ChangeLog: AravisProject/aravis#620

PR:	261103
Reported by:	rozhuk.im@gmail.com (maintainer)
Reviewed by:	diizzy@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmanuelP EmmanuelP Awaiting requested review from EmmanuelP

Assignees
No one assigned
Labels
5. Gige Issue in the GigEVision implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozhuk-im @EmmanuelP