Enhancement/703/multiple taps #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Sorry for the late reply. I don't think we can select gain or black level using defined integer values. There is no guarantee a selector value is always mapped to the same string. arv_camera_select_gain and arv_camera_select_black_level should use a string as the selector parameter. |
EmmanuelP
force-pushed
the
enhancement/703/multiple-taps
branch
from
74bbb41 to
4566022
Compare
EmmanuelP
requested changes
Jan 17, 2023
|
@EmmanuelP, is this at least more of what you had in mind? raw strings? i guess it doesn't buy you all that much now since it just wraps to the arv_camera_set_string() method. |
EmmanuelP
requested changes
Mar 10, 2023
update since statements in code comments
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#703