Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal metrics with Micrometer #1850

Closed
robfrank opened this issue Dec 5, 2024 · 3 comments
Closed

Replace internal metrics with Micrometer #1850

robfrank opened this issue Dec 5, 2024 · 3 comments
Assignees
Milestone

Comments

@robfrank
Copy link
Collaborator

robfrank commented Dec 5, 2024

ArcadeDB has an internal metric/monitorinfg component and a http endpoint that provides some data in a custom format.

The idea is to replace the component using Micrometer (https://micrometer.io/) to gather internal metrics, adding more meters (counter, gauge, etc.) where necessary and provide standard ways to connect to monitoring services: prometheus, graphite, etc.

  • remove the internal metric component
  • add micrometer and replace previous meter
  • for back compatibility map new metrics to old names/values on the http endpoint
  • implement a Prometheus ServerPlugin as the first integration point
  • add documentation covering configuration and integration with external tools
@gramian
Copy link
Collaborator

gramian commented Dec 5, 2024

I would appreciate Prometheus via this way for metrics via HTTP.

@lvca
Copy link
Contributor

lvca commented Dec 5, 2024

Back compatibility is not super important (never documented), but Studio: the metrics should show up there.

@gramian
Copy link
Collaborator

gramian commented Dec 5, 2024

And the JMX metrics are for development only, right?

robfrank added a commit that referenced this issue Dec 19, 2024
…MetricsPlugin, test for PrometheusMetricsPlugin, add configuration param to enable/disable auth
mergify bot added a commit that referenced this issue Dec 19, 2024
…ometer

#1850 disable internal metric service, add micrometer, add PrometheusMetricsPlugin
@lvca lvca modified the milestones: 24.12.1, 25.1.1 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants