Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create property default value assignment #1611

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented May 20, 2024

What does this PR do?

This change syncs the the assignment of a default value in CREATE PROPERTY to the way it is done in ALTER PROPERTY (see https://github.com/ArcadeData/arcadedb/blob/main/engine/src/main/java/com/arcadedb/query/sql/parser/AlterPropertyStatement.java#L96 ).

Motivation

Using sysdate in a default value was evaluated at property creation time not at record creation time.

Related issues

#1609

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-requested a review May 21, 2024 17:34
@lvca lvca added this to the 24.5.1 milestone May 21, 2024
@lvca lvca added the bug Something isn't working label May 21, 2024
@lvca
Copy link
Contributor

lvca commented May 21, 2024

Awesome, thanks @gramian !

@lvca lvca merged commit 6841fe3 into ArcadeData:main May 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants