Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve security: add sha to gihub actions #1804

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

robfrank
Copy link
Collaborator

What does this PR do?

Improve security of CI/CD pipeline adding sha reference to every github action used in the workflows.
It also adds https://github.com/marketplace/actions/ensure-sha-pinned-actions to check that every action used in workflows has the sha.

Motivation

As suggested in https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions:

  • Pin actions to a full length commit SHA

  • Audit the source code of the action

  • Pin actions to a tag only if you trust the creator

  • I have run the build using mvn clean package command

  • My unit tests cover both failure and success scenarios

@robfrank robfrank self-assigned this Oct 31, 2024
@robfrank robfrank added this to the 24.11.1 milestone Oct 31, 2024
@robfrank robfrank merged commit d196555 into main Oct 31, 2024
4 of 8 checks passed
@robfrank robfrank deleted the improvement/add-sha-to-gh-action branch October 31, 2024 16:08
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (affcb0c) 71964 38928 54.09%
Head commit (db246b5) 71964 (+0) 38923 (-5) 54.09% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1804) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant