Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed html injection based on node content #1849

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ExtReMLapin
Copy link
Contributor

What does this PR do?

Fixes #1848

Motivation

At the office we had fun adding the cheeki breeki image but for the sake of seriousness, it needed to be fixed

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

I DID NOT test it, but it should work considering the very low complexity of the changes

@lvca lvca self-requested a review December 2, 2024 18:28
@lvca lvca added bug Something isn't working security labels Dec 2, 2024
@lvca lvca added this to the 24.11.2 milestone Dec 2, 2024
Copy link
Contributor

@lvca lvca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 thanks!

@lvca lvca merged commit bd7fe63 into ArcadeData:main Dec 2, 2024
2 checks passed
@ExtReMLapin ExtReMLapin deleted the html-injection-patch branch December 2, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Studio] Studio interprets strings as HTML
2 participants