Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1515 fix date formatting in JSONObject, add tests #1887

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented Jan 2, 2025

What does this PR do?

Add a date formatter for LocalDataTime to JsonObject.

Motivation

The JsonObjet has a single DateTimeFormater dedicated to Date and doen't provide a dedicated formatter for LocalDatetime, but inside the database there are 2 different formatters configurable with properties:

        alter database `arcadedb.dateImplementation` `java.time.LocalDate`;
        alter database `arcadedb.dateTimeImplementation` `java.time.LocalDateTime`;
        alter database `arcadedb.dateFormat` 'dd MM yyyy GG';
        alter database `arcadedb.dateTimeFormat` 'dd MM yyyy GG HH:mm:ss';

Related issues

#1515

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank requested a review from lvca January 2, 2025 20:38
Copy link

codacy-production bot commented Jan 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% 87.93%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1653a85) 68165 43617 63.99%
Head commit (0a91b2a) 68186 (+21) 43670 (+53) 64.05% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1887) 58 51 87.93%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mergify mergify bot merged commit db04e77 into main Jan 2, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants