Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1898 complete review of SelectExecutionPlanner #1900

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented Jan 8, 2025

What does this PR do?

I did a complete review of the SelectExceutionPlanner:

  • chore: use of Type and Buckets
  • re-enable commented parts

Motivation

Working on fixing #1898

Related issues

Additional Notes

Anything else we should know when reviewing?

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank requested a review from lvca January 8, 2025 10:46
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e557e8d1 88.68%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e557e8d) Report Missing Report Missing Report Missing
Head commit (e54edc1) 68177 43695 64.09%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1900) 159 141 88.68%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@mergify mergify bot merged commit d0aa142 into main Jan 8, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants