Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default buckets per type to 1 #1903

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Changed default buckets per type to 1 #1903

merged 4 commits into from
Jan 9, 2025

Conversation

lvca
Copy link
Contributor

@lvca lvca commented Jan 9, 2025

Branch to fix #1902

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

Anything else we should know when reviewing?

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca added the enhancement New feature or request label Jan 9, 2025
@lvca lvca requested a review from robfrank January 9, 2025 14:48
Copy link

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d0aa142) 68177 43687 64.08%
Head commit (10f4dc1) 68176 (-1) 43652 (-35) 64.03% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1903) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@lvca lvca self-assigned this Jan 9, 2025
@lvca lvca added this to the 25.1.1 milestone Jan 9, 2025
@lvca lvca removed the request for review from robfrank January 9, 2025 23:47
@lvca lvca marked this pull request as ready for review January 9, 2025 23:48
@lvca lvca merged commit bc3868c into main Jan 9, 2025
5 of 7 checks passed
@lvca lvca deleted the issue-1902 branch January 9, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default number of buckets per type to 1
1 participant