Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline the purpose of the repository and generate project metadata #1

Merged
merged 9 commits into from
Aug 23, 2022

Conversation

taylorreiter
Copy link
Member

@taylorreiter taylorreiter commented Aug 22, 2022

This pull request starts this repository. It does two things:

  1. starts an aspirational README file. The README describes the purpose of the repository and what the code will eventually do. It also outlines sections that will be filled in as the code is written and run.
  2. programmatically generates a metadata file that will be ingested by the pipeline to accomplish the repository's goals.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@taylorreiter taylorreiter marked this pull request as draft August 22, 2022 14:31
@taylorreiter taylorreiter changed the title Make metadata Outline the purpose of the repository and generate project metadata Aug 22, 2022
@taylorreiter taylorreiter marked this pull request as ready for review August 22, 2022 15:17
README.md Outdated Show resolved Hide resolved
Copy link
Member

@borgesadair1 borgesadair1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than the mtxx typo which i hope to have corrected in line.

@@ -0,0 +1,5079 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in header : availabl --> available


Reply via ReviewNB

inputs/metadata-parse-paired-mgx-mtx.ipynb Show resolved Hide resolved
@@ -0,0 +1,5079 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we combine human_gut and human_gut_microbiome


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes great catch, thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed _microbiome from snail_gut bc they're all microbiomes and that was the only one that still had it in it.

taylorreiter and others added 3 commits August 23, 2022 07:26
Co-authored-by: Adair Borges <68403591+borgesadair1@users.noreply.github.com>
@taylorreiter taylorreiter merged commit b6fe0a9 into main Aug 23, 2022
@taylorreiter taylorreiter deleted the make_metadata branch August 30, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants