make job status less chatty #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference is noisy for nothing - it's already in the channel topic and it's not used in other commands which might also need it (e.g. plain `!status`).
The job status is currently two verbose and spams the channel with four lines of log. So instead of: ``` 09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz 09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>: 09:45:53 <Major> anarcat: Started by anarcat. 09:45:53 <Major> anarcat: In progress. Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued. 09:45:53 <Major> anarcat: 4 workers, delay: [0.0, 0.0] ms. 09:45:53 <Major> anarcat: See the ArchiveBot dashboard for more information. ``` We should be seeing something like: ``` 09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz 09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>. Started by anarcat. In progress. Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued. anarcat: 4 workers, delay: [0.0, 0.0] ms. ``` Untested: ideally, we'd just return a string instead of an array here, but I'm trying to respect the existing API to avoid breaking too much stuff.
... and the rest of the universe
kiska3
approved these changes
Sep 22, 2018
JustAnotherArchivist
approved these changes
Sep 22, 2018
This was referenced Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job status is currently two verbose and spams the channel with four lines of log.
So instead of:
We should be seeing something like:
Untested: ideally, we'd just return a string instead of an array here, but I'm trying to respect the existing API to avoid breaking too much stuff. But I did test that the bot framework correctly splits long lines: cinch handles that fine.
We also remove the dashboard reference because it is noisy for nothing - it's already in the channel topic and it's not used in other commands which might also need it (e.g. plain
!status).While we here, switch to using MiB to be consistent with dashboard and the rest of the universe.