Lists #2
Lists #2
Conversation
…, from albums to tracks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
app/src/main/java/com/archrahkshi/spotifine/ui/MainActivity.kt|42| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/MainActivity.kt|62| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|13| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|18| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|21| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|45| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|53| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt|61| Line has trailing spaces.
app/src/main/java/com/archrahkshi/spotifine/data/LibraryListsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/data/LibraryListsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/data/LibraryListsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/data/LibraryListsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/data/LibraryListsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LibraryActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LibraryActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LibraryActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LibraryActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/archrahkshi/spotifine/ui/LyricsFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|11 col 1| Wildcard import (cannot be auto-corrected)
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|29 col 35| Parameter should be on a separate line (unless all parameters can fit a single line)
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|29 col 58| Parameter should be on a separate line (unless all parameters can fit a single line)
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|49 col 31| Argument should be on a separate line (unless all arguments can fit a single line)
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|49 col 31| Missing newline after "("
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|52 col 17| Missing newline before ")"
app/src/main/java/com/archrahkshi/spotifine/ui/TracksFragment.kt|52 col 18| Missing newline before ")"
| @@ -0,0 +1,59 @@ | |||
| package com.archrahkshi.spotifine.data | |||
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
File must end with a newline (\n)
| @@ -0,0 +1,33 @@ | |||
| package com.archrahkshi.spotifine.data | |||
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
File must end with a newline (\n)
| } else { | ||
| appRemote.playerApi.seekTo(seekBar.progress.toLong()) | ||
| } | ||
|
|
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Unexpected blank line(s) before "}"
| appRemote.playerApi.resume() | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline before ")"
|
|
||
| // Something went wrong when attempting to connect! Handle errors here | ||
| } | ||
| }) |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline before ")"
|
|
||
| // Something went wrong when attempting to connect! Handle errors here | ||
| } | ||
| }) |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline before ")"
| @@ -0,0 +1,115 @@ | |||
| package com.archrahkshi.spotifine.ui | |||
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
File must end with a newline (\n)
| .setRedirectUri(REDIRECT_URI) | ||
| .showAuthView(true) | ||
| .build() |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| .setRedirectUri(REDIRECT_URI) | ||
| .showAuthView(true) | ||
| .build() |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline after "("
| .setRedirectUri(REDIRECT_URI) | ||
| .showAuthView(true) | ||
| .build() |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| seekBar.max = duration.toInt() | ||
| var flag = 0 | ||
| buttonPlay.text = "PLAY" |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| buttonPlay.text = "PLAY" | ||
| seekBar.setOnSeekBarChangeListener(object : OnSeekBarChangeListener { | ||
| override fun onProgressChanged(seekBar: SeekBar, i: Int, b: Boolean) { |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Unnecessary space(s)
| override val coroutineContext: CoroutineContext = Dispatchers.Main.immediate | ||
| ) : Fragment(), CoroutineScope { | ||
| override fun onCreateView( | ||
| inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle? |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Parameter should be on a separate line (unless all parameters can fit a single line)
| createTrackLists(args?.getString(URL), args?.getString(ACCESS_TOKEN)) | ||
| ) { | ||
| Log.i("Track", it.toString()) | ||
| startActivity(Intent(activity, PlayerActivity::class.java).apply { |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| createTrackLists(args?.getString(URL), args?.getString(ACCESS_TOKEN)) | ||
| ) { | ||
| Log.i("Track", it.toString()) | ||
| startActivity(Intent(activity, PlayerActivity::class.java).apply { |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline after "("
| startActivity(Intent(activity, PlayerActivity::class.java).apply { | ||
| putExtra(ID, it.id) | ||
| putExtra(DURATION, it.duration) | ||
| }) |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline before ")"
| startActivity(Intent(activity, PlayerActivity::class.java).apply { | ||
| putExtra(ID, it.id) | ||
| putExtra(DURATION, it.duration) | ||
| }) |
There was a problem hiding this comment.
[ktlint] reported by reviewdog 🐶
Missing newline before ")"
|
ktlint problem: pinterest/ktlint#527 |
No description provided.