Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a graceful error message for logging in #4501

Closed
mkoo opened this issue Mar 31, 2022 · 12 comments
Closed

Need a graceful error message for logging in #4501

mkoo opened this issue Mar 31, 2022 · 12 comments
Labels
Display/Interface I don't like the way Arctos looks or it isn't working for me aesthetically. Enhancement I think this would make Arctos even awesomer! Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.

Comments

@mkoo
Copy link
Member

mkoo commented Mar 31, 2022

If you click on a link from your email without being logged into Arctos you get an annoying error message (see below). This is a serious impediment to taking notifications seriously and is misleading (i.e., Arctos is not 'broken')

Instead, please change this type of error to a useful one, for example:
"The page you are trying to access requires logging into your Arctos account. Please log in below"

then provide the login fields (skip the burning workstation, how about the Arctos bear instead!)

I have been already receiving complaints...

Here's one example:
Screen Shot 2022-03-31 at 8 17 22 AM

@mkoo mkoo added Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. Enhancement I think this would make Arctos even awesomer! Display/Interface I don't like the way Arctos looks or it isn't working for me aesthetically. labels Mar 31, 2022
@Jegelewicz
Copy link
Member

YES PLEASE

@dustymc
Copy link
Contributor

dustymc commented Mar 31, 2022

When we had more informative error messages we also had a steady stream of "hackers" trying to exploit them. Arctos gets considerably more traffic than it did then. I can do WHATEVER with the generic error, but I'm not sure we have the resources to deal with the inevitable effects of being much more specific.

I'm emotionally attached to the lowres smoking computer gif, but mock up something else and I'll replace it - and then go cry in the corner....

@dustymc dustymc added this to the Needs Discussion milestone Mar 31, 2022
@mkoo
Copy link
Member Author

mkoo commented Mar 31, 2022

When we had more informative error messages we also had a steady stream of "hackers" trying to exploit them. Arctos gets considerably more traffic than it did then. I can do WHATEVER with the generic error, but I'm not sure we have the resources to deal with the inevitable effects of being much more specific.

Well, we get this particular error message a lot ...

I'm emotionally attached to the lowres smoking computer gif, but mock up something else and I'll replace it - and then go cry in the corner....

I know and I will supply hankies! (plus I'm not asking you to scrub our little smoking friend entirely....) Just in this context it's gotta go. Ok, mockups to come for a generic error

@ewommack
Copy link

You could have a little computer gif with a key hole to represent you need to get access maybe?

@mkoo
Copy link
Member Author

mkoo commented Apr 1, 2022

Draft generic error message in google doc for direct editing and comments (html at bottom of doc)

Please suggest other solutions to things that may be triggering that a generic error....

@dustymc
Copy link
Contributor

dustymc commented Apr 6, 2022

This needs more discussion.

The "pretty" error isn't sufficient for users to solve problems (see #4515, #4518). Suggest, at least as a starting point:

  1. Public users keep getting what they get now
  2. "Us" - Operators with role coldfusion_user - get the raw error dump.

Thoughts?

@wellerjes
Copy link

I agree with the idea of having different error screens; I'd prefer to have something that clues me in to what I'm doing wrong, especially with regards to bulkloading.

@mkoo
Copy link
Member Author

mkoo commented Apr 6, 2022 via email

@Jegelewicz
Copy link
Member

The issue seems to be that we can have only ONE error message? Why is that? When I am doing something dumb in Agent Prebulkloader (adding a new status, but not checking anything to change) I get this exact same message. I sometimes figure out what has gone awry and sometimes I don't. The proposed change was for

If you click on a link from your email without being logged into Arctos you get an annoying error message (see below). This is a serious impediment to taking notifications seriously and is misleading (i.e., Arctos is not 'broken')

but now it's what we get for everything. I suspect the user community is used to more tailored messages when they do something wrong in a webform. If we can figure out how to customize some of our error messages, Dusty won't have to answer everyone's repeated questions about them.

@mkoo
Copy link
Member Author

mkoo commented Apr 6, 2022 via email

@dustymc
Copy link
Contributor

dustymc commented Apr 6, 2022

blurry line...two different states

Yes, they're logged in as an Operator or not. "Trying to get there" is "not."

not the first and only thing

Agreed, but #4509 is rapidly turning into the rabbit hole of rabbit holes - I can dump for us now(ish), doing more needs some other stuff straightened out first and that is looking like that's going to take a while. I'm voting for "just dump, make it pretty when possible" but happy to be overridden.

ONE error message? Why is that?

#4501 (comment)

Our security team (or lack thereof...) demands uninformative errors for "not-us." "Us" is welcome to see the gritty details, I just live a limited capacity to make it less-gritty at the moment.

@dustymc
Copy link
Contributor

dustymc commented Apr 11, 2022

Test is (slowly) coming back together with much more robust error handling, including a centralized mechanism to sort and customize exceptions. Initially public users will get a bit more information in specific circumstances (specimenresults timing out), operators will get a dump (first a "summary table" then a raw exception) below a hopefully-nice (but likely not very informative) message. It should be straightforward to adjust and tune under this mechanism, but if anyone wants to go break test, logged in and/or out, I can adjust things before this goes to production.

The low-res melting computer is nowhere to be found, I still want my hankie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display/Interface I don't like the way Arctos looks or it isn't working for me aesthetically. Enhancement I think this would make Arctos even awesomer! Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.
Projects
None yet
Development

No branches or pull requests

5 participants