Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Table Cleanup - Record Attribute = gonad #4774

Closed
Jegelewicz opened this issue Jun 17, 2022 · 26 comments
Closed

Code Table Cleanup - Record Attribute = gonad #4774

Jegelewicz opened this issue Jun 17, 2022 · 26 comments
Labels
CodeTableCleanup Our bad data leads to more bad data. Fix it!

Comments

@Jegelewicz
Copy link
Member

We currently have what appears to be a part in the catalog record attribute type code table.

gonad

A mixed gland that produces the gametes and sex hormones of an organism. Wikipedia

I think this should probably be gonad length? It requires a numeric value and units of measure.

Suggest we add gonad length, move all gonad attributes to it and remove gonad.

@Jegelewicz Jegelewicz added Function-CodeTables CodeTableCleanup Our bad data leads to more bad data. Fix it! labels Jun 17, 2022
@Jegelewicz
Copy link
Member Author

Actually, based on usage, we should also add gonad width and the gonad attributes will need to be moved to the appropriate attribute.

See https://arctos.database.museum/guid/CHAS:Bird:2020.9.9
image

@dustymc
Copy link
Contributor

dustymc commented Jun 17, 2022

temp_gonad.csv

@wellerjes
@lin-fred
@droberts49
@kderieg322079
@catherpes,@catherpes
@acdoll

This should probably be moved to reproductive data (free text) and dropped - it's all sorts of things, including something that weighs 0.0624 fathoms....

@dustymc dustymc added this to the Needs Discussion milestone Jun 17, 2022
@Jegelewicz
Copy link
Member Author

I found the fathom thing and alerted the collection....

@Jegelewicz
Copy link
Member Author

I think each collection should move it to wherever it makes sense. (The fathom thing should be using gonad weight). They probably need eyeballs on them to get them in the right place.

@Jegelewicz
Copy link
Member Author

https://arctos.database.museum/guid/MSB:Bird:19552

seems like it should be gonad length and gonad width

image

@lin-fred
Copy link
Contributor

https://arctos.database.museum/guid/MSB:Bird:19552

seems like it should be gonad length and gonad width

image

That's also the reason for our NMMNH record as well. If not this way, what would be the better way?

@Jegelewicz
Copy link
Member Author

what would be the better way?

That is pretty much what I am suggesting with this issue. That we add gonad length and gonad width.

BUT

this is a bit of a cluster because we also have

right gonad length
left gonad length
right gonad width
left gonad width

so when you don't know if it is left or right, you are stuck

@catherpes
Copy link

that Trotter MSB BIRD record is someone entering data in a nonsensical manner making a lot more work for themselves then and us now. I have updated it.

@dustymc
Copy link
Contributor

dustymc commented Jun 17, 2022

cluster because we also have

Question for the ornithologists: how much of this is Research Grade? Are we recording this because someone could have a plausible "sciencey" reason to search by eg right gonad length, or would these data be equally useful in something like reproductive data? (The remarks and such in these data make me think gonad is not very useful by itself, but that's a tiny sample size.) We probably have to find a way to support whatever is necessary to do science, but having lots of attributes is not without cost. If we can find a way to eliminate some attributes without losing any functionality, we should do so.

@Jegelewicz
Copy link
Member Author

@ccicero

@catherpes
Copy link

Generally, birds have only one ovary, the left, so this mostly refers to male birds, with the exception of Raptors which can have two ovaries and the right one is reduced. In collections where left and right testis sizes have been recorded separately, there has been at least one paper that has looked at that phenomenon. And I don't remember anything about it beyond that. Maybe a collection somewhere has a series of raptors with right ovary measurements already parsed out and would not want to lose that effort. I question why right gonad length would be separated from right gonad width. 'right gonad dimensions' would seem to be fine.
So, it can be useful to parse out the data that fine. I'm happy with reproductive data being free-form text at this point in this collection because unless one is quite different than the other, we generally do not record them separately.

@ewommack
Copy link

There has been more work presented at recent conferences that show that there may be differences in testes size depending on species and conditions. I think the fact that more museums are starting to record both testes sizes isn't know yet, but having the data there I think will be really valuable. More so as well, as people are taking one testis for RNAlater sampling, and often we are left with measuring the right for some of those birds. Having both measurements with all the non-sampled birds would make more data available for comparisons.

For the ovaries - actually there are a lot more birds that can have two ovaries then we normally think. Kiwis apparently have two ovaries regularly. It has popped up in a variety of other groups as well. There are probably the most data on it in the diurnal birds of prey, because people know to look for it. Accipiters are the most reliable having two ovaries, but other taxon groups also have it. There are more published articles on this topic. It is still debated on whether the second ovary may be viable. I just always tell me students to check both sides no matter what. We found it in a second ovary in a grebe thanks to that.

@dustymc
Copy link
Contributor

dustymc commented Mar 7, 2024


 guid_prefix | count 
-------------+-------
 MMNH:Bird   |     1
 CHAS:Bird   |     2
 NMMNH:Bird  |     2
 UMNH:Bird   |     1
 MLZ:Bird    |     1

@wellerjes
Copy link

Just removed gonad from CHAS:Bird records.

@lin-fred
Copy link
Contributor

lin-fred commented Mar 7, 2024

NMMMH is removed as well

@Jegelewicz
Copy link
Member Author

Slim this down to gonad length and gonad width - move left and right to method.

@mkoo
Copy link
Member

mkoo commented Mar 7, 2024

Alrighty, this was discussed in Issues meeting by the AWG-- here's the conclusions:
add in measurement attributes of gonad length, gonad width, gonad weight-- users should use methods to indicate left or right or unknown

This would make usable for all vertebrates.
I will start new requests for the above and leave notes on all affected CT requests. This issue can remain open until these 5 records are updated appropriately.

MMNH:Bird | 1
CHAS:Bird | 2
UMNH:Bird | 1
MLZ:Bird | 1

@dustymc
Copy link
Contributor

dustymc commented Mar 8, 2024

Fresh data:

temp_gonad.csv

Summary:


 guid_prefix | count 
-------------+-------
 MMNH:Bird   |     1
 UMNH:Bird   |     1
 MLZ:Bird    |     1

contacts

@barke042
@adhornsby
@kderieg322079

@adhornsby
Copy link

MMNH cleaned up... and we promise to stop measuring our bird testes in fathoms.

@dustymc dustymc mentioned this issue Mar 8, 2024
@Jegelewicz
Copy link
Member Author

UMNH:Bird separated into left gonad length and width

@dustymc
Copy link
Contributor

dustymc commented Aug 16, 2024

@mkoo help - can I just move this to https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#reproductive_data ?

 guid_prefix | count 
-------------+-------
 CHAS:Bird   |     1
 MLZ:Bird    |     1

ghaddr

@droberts49
@wellerjes

@wellerjes
Copy link

Updated CHAS:Bird record.

@campmlc
Copy link

campmlc commented Sep 3, 2024

ANSP:Host have gonad attributes, with more in the component loader associated with @Jegelewicz . Can these be converted?

attributeDataDownload gonad.csv

@campmlc
Copy link

campmlc commented Sep 3, 2024

Also, just to clarify from the bird folks - what gonad is being measured here? Mammalogists measure testes, and need to be able to designate that the "gonad" is a testis measurement. But I don't see that in bird records. How do we distinguish? Mammal folks would prefer to use the term "testes", but can grudgingly use "gonad" only if "testes can be made explicit. Is this "gonad" measurement for birds actually a testis measurement?

@campmlc
Copy link

campmlc commented Sep 3, 2024

@jldunnum @bryansmclean

@dustymc
Copy link
Contributor

dustymc commented Sep 6, 2024

merge-->#7504

@dustymc dustymc closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CodeTableCleanup Our bad data leads to more bad data. Fix it!
Projects
None yet
Development

No branches or pull requests

9 participants